Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat @Value as a type annotation #1367

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Don't treat @Value as a type annotation #1367

merged 2 commits into from
Oct 14, 2022

Conversation

mernst
Copy link
Contributor

@mernst mernst commented Oct 11, 2022 •
edited

@mernst mernst mentioned this pull request Oct 11, 2022
Merged
@nedtwigg
Copy link
Member

I'm okay with this, but we need to add it in all three changelogs like so:

[Unreleased]
### Fixed
* Some message (link to PR)

I'm not sure what the changelog message should be, I'm happy to merge anything.

@mernst
Copy link
Contributor Author

mernst commented Oct 13, 2022

Thanks for the feedback. I wasn't sure whether the change merited a changelog entry. I have now added them as you requested.

@nedtwigg nedtwigg merged commit 8b24963 into diffplug:main Oct 14, 2022
@nedtwigg
Copy link
Member

nedtwigg commented Oct 14, 2022 •
edited

Thanks for the PR! I could publish a release with only this change, but I have a slight preference to wait for a more substantial new feature or bugfix before creating the notification noise of a new release. Please speak up if you'd like me to publish now though, it's not a big deal :)

@mernst mernst deleted the valuetypeanno branch October 14, 2022 14:34
@mernst
Copy link
Contributor Author

mernst commented Oct 14, 2022

Either way is fine with me. Thanks!

@nedtwigg
Copy link
Member

Published in plugin-gradle 6.12.0 and plugin-maven 2.28.0.

valfirst added a commit to vividus-framework/vividus-build-system that referenced this pull request Nov 28, 2022
@valfirst
Revert "Revert "Apply Spotless step formatAnnotations()""
6a42656 
This reverts commit 2a4ee5d.

Spotless issue is fixed: diffplug/spotless#1367
benkard added a commit to benkard/mulkcms2 that referenced this pull request Apr 2, 2023
@benkard
Update dependency com.diffplug.spotless:spotless-maven-plugin to v2.3…
304c965 
…1.0 (mulk/mulkcms2!12)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | minor | `2.30.0` -> `2.31.0` |

---

### Release Notes

<details>
<summary>diffplug/spotless</summary>

### [`v2.31.0`](https://github.com/diffplug/spotless/blob/HEAD/CHANGES.md#&#8203;2310---2022-11-24)

##### Added

-   `importOrder` now support groups of imports without blank lines ([#&#8203;1401](diffplug/spotless#1401))

##### Fixed

-   Don't treat `@Value` as a type annotation [#&#8203;1367](diffplug/spotless#1367)
-   Support `ktlint_disabled_rules` in `ktlint` 0.47.x [#&#8203;1378](diffplug/spotless#1378)
-   Share git repositories across projects when using ratchet ([#&#8203;1426](diffplug/spotless#1426))

##### Changes

-   Bump default `ktfmt` version to latest `0.40` -> `0.41` ([#&#8203;1340](diffplug/spotless#1340))
-   Bump default `scalafmt` version to latest `3.5.9` -> `3.6.1` ([#&#8203;1373](diffplug/spotless#1373))
-   Bump default `diktat` version to latest `1.2.3` -> `1.2.4.2` ([#&#8203;1393](diffplug/spotless#1393))
-   Bump default `palantir-java-format` version to latest `2.10` -> `2.28` ([#&#8203;1393](diffplug/spotless#1393))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mernst @nedtwigg