Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #540 #1158

Merged
merged 3 commits into from Apr 6, 2022
Merged

Fix #540 #1158

merged 3 commits into from Apr 6, 2022

Conversation

arulrajnet
Copy link
Contributor

@arulrajnet arulrajnet commented Apr 2, 2022

Fix for #540 which was broken in #1119

@nedtwigg Tested in local. Now the .gitconfig in user directory is taken care. Tested with SNAPSHOT build and it works. Is there anything else I have to update / test.

- Take care of system and user config
@nedtwigg
Copy link
Member

nedtwigg commented Apr 3, 2022

Thanks for the PR!

https://app.circleci.com/pipelines/github/diffplug/spotless/1883/workflows/6f5f82a2-ab75-41ba-b208-b7abaaf57260/jobs/10757

Looks like tests aren't compiling. The criteria to get this merged and released are:

  • fix tests, get them to pass (./gradlew testClasses and ./gradlew test)
  • update all three changelogs with
## [Unreleased]
### Fixed
- blah blah blah

@arulrajnet
Copy link
Contributor Author

@nedtwigg Done. The tests are passed now.

@arulrajnet
Copy link
Contributor Author

@nedtwigg what is the next step? Gentle reminder.

@nedtwigg
Copy link
Member

nedtwigg commented Apr 6, 2022

Sorry, thanks for the reminder!

@nedtwigg nedtwigg merged commit e1d34dc into diffplug:main Apr 6, 2022
@nedtwigg
Copy link
Member

nedtwigg commented Apr 6, 2022

Released in plugin-gradle 6.4.2 and plugin-maven 2.22.1

@arulrajnet arulrajnet deleted the Fix-for-540 branch April 7, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants