Implemented max lines width changing support for Kotlin ktfmt formatter for Gradle plugin. #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDeg
force-pushed
the
ktfmt-max-width-parameter-gradle
branch
from
0e63290
to
0e01cd4
Compare
DDeg
force-pushed
the
ktfmt-max-width-parameter-gradle
branch
5 times, most recently
from
0b400ce
to
a50cf0a
Compare
nedtwigg
requested changes
Mar 11, 2022
There was a problem hiding this comment.
- Update
CHANGES.md(not justplugin-gradle/CHANGES.md)
Once that is done I'm happy to merge this as-is, but this would probably be a lot easier with #524. Do you want to refactor to that approach? If you want to add other ktfmt features in the future, it would probably be worth the refactor.
DDeg
force-pushed
the
ktfmt-max-width-parameter-gradle
branch
7 times, most recently
from
e12aec3
to
9b828e9
Compare
DDeg
force-pushed
the
ktfmt-max-width-parameter-gradle
branch
from
9b828e9
to
336241d
Compare
DDeg
force-pushed
the
ktfmt-max-width-parameter-gradle
branch
from
336241d
to
fb62f36
Compare
|
Updated review with new approach with compileOnly dependency usage. |
nedtwigg
approved these changes
Mar 28, 2022
|
Published in |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.