Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to CDT version 2021-12 / 10.5. #1030

Merged
merged 2 commits into from Dec 11, 2021
Merged

Upgraded to CDT version 2021-12 / 10.5. #1030

merged 2 commits into from Dec 11, 2021

Conversation

max-leuthaeuser
Copy link
Contributor

No description provided.

@fvgh fvgh merged commit 6a9bc8d into diffplug:main Dec 11, 2021
@fvgh
Copy link
Member

fvgh commented Dec 11, 2021

Thanks for the input @max-leuthaeuser. Just triggered the release.

As soon as the new version is available on maven central (in a few hours), you can provide with a second PR a new dependency lock file and change the default version.

The new default version is used automatically by the tests, so no further changes required. But you could make a local snapshot release of Spotless (Maven or Gradle plugin) and apply it on your project.

Please have a look at the existing dependency lock files. They basically contain the gradle compile lock file content, but I omit for example the slf4j API, since I see no benefit to override the provided one.

And we also need updates of all the change logs ( main, plugin-gradle, plugin-maven).

@fvgh
Copy link
Member

fvgh commented Dec 11, 2021

@nedtwigg please remind me...
The publishing of the new CDT plugin fails.

java.lang.Error: p2asmaven requires JRE 8, this is JRE 11

I used p2asmaven with JRE 11, but I think the problem was introduced by a later version of p2asmaven.
I think we had this problem before and I fixed it with #874. Now we use p2asmaven as a direct build dependency.
Shall we go back to an older version?

@max-leuthaeuser
Copy link
Contributor Author

Thanks for triggering the release. Have you been able to figure out how to fix the publishing?

I am not using spotless directly. Just spotless-eclipse-cdt the get the (headless, standalone) cdt internals (e.g., the CDT parser + AST).
Hence, I am not familiar with the build internals / configuration here within spotless and I am unable to provide the mentioned lock file etc.

nedtwigg added a commit that referenced this pull request Dec 13, 2021
@nedtwigg
Copy link
Member

10.5.0 has been released, we had two problems.

  1. I screwed up the ext build at some point by upgrading the goomph dependency, my bad. Thanks @fvgh for pointing out the PR where we fixed this in the past, I fixed it again and added a comment so hopefully I don't break it again.
  2. The changelog should have the changes under [Unreleased], the build automatically calculates the version number and puts the release date into the changelog.

Both problems were fixed, and 10.5.0 is now available on mavencentral.

@max-leuthaeuser
Copy link
Contributor Author

I can see that the corresponding jobs for the release are not yet approved (in your CircleCI pipeline).
This needs to be done manually? Maven central does not yet have an artifact for 10.5.

@nedtwigg
Copy link
Member

Sorry, I think it should have 10.5.0 now. I did a manual approval of a release for 10.5 here, but it timed out at 10 minutes. I logged into sonatype to manually release the artifact, and I thought I had successfully done so, but it turned out I missed a step.

@max-leuthaeuser
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants