C++ front-end fixes #8275
Draft
C++ front-end fixes #8275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8275 +/- ##
===========================================
- Coverage 77.55% 77.34% -0.21%
===========================================
Files 1721 1721
Lines 190128 190891 +763
Branches 18438 18411 -27
===========================================
+ Hits 147448 147648 +200
- Misses 42680 43243 +563 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
bugfixes/cpp-constexpr
branch
3 times, most recently
from
f4916a1
to
bb79589
Compare
Required to parse cassert (which in turn includes stdlib.h) on macOS in C++11 mode.
LLVM's standard library uses these in type_traits.
We had parentheses consumed by rCommaExpression while still expecting to find one after this rule executed.
Seen in GCC's STL.
The example included as regression test has a bool instead.
We also need to pop one token, not just replace the existing ones.
Now follows the grammar described in the C++ standard: Explicit type conversions are postfix expressions.
Mark `constexpr` symbols as macros and use direct replacement (non-function symbols) or in-place evaluation (uses of `constexpr` function symbols).
Attach the "ellipsis" information to the declarator and not to the type.
tautschnig
force-pushed
the
bugfixes/cpp-constexpr
branch
from
bb79589
to
04bcc91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit-by-commit. This gets us somewhat closer to being able to process
type_traits.