Declutter linking implementation #8168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8168 +/- ##
===========================================
- Coverage 78.23% 78.21% -0.02%
===========================================
Files 1720 1724 +4
Lines 188342 188397 +55
Branches 18441 18443 +2
===========================================
+ Hits 147353 147359 +6
- Misses 40989 41038 +49 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
cleanup/linking-cleanup
branch
from
e226550
to
fc5fc90
Compare
Reduce the amount of code by getting rid of those thin wrappers around
from_{expr,type}.
Increase readability of linking code by moving aside code that is not specific to just linking.
This is a large amount of code that is solely concerned with producing information that seeks to be helpful to a (human) user. Moving this to its own translation unit should increase the readability of core linking algorithms.
tautschnig
force-pushed
the
cleanup/linking-cleanup
branch
from
fc5fc90
to
310eb16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes in behaviour intended in this PR: each commit removes unnecessary code or moves it to a separate translation unit. Overall, this should improve the readability of the linking implementation.