Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated messaget() constructor #8143

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

It is now no longer possible to construct a messaget object that is not fully configured, i.e., lacks a message handler.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is never needed or used and would require default-constructing a
messaget, which is no longer possible.
It is now no longer possible to construct a messaget object that is not
fully configured, i.e., lacks a message handler.
@tautschnig tautschnig force-pushed the cleanup/parsert-message-handler branch from f73a775 to 8faffdb Compare March 19, 2024 12:21
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (1fd7011) to head (8faffdb).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8143   +/-   ##
========================================
  Coverage    79.64%   79.64%           
========================================
  Files         1684     1684           
  Lines       195606   195582   -24     
========================================
- Hits        155791   155780   -11     
+ Misses       39815    39802   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant