Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo's audit allowlist that is no longer needed #3617

Merged
merged 2 commits into from
May 2, 2023

Conversation

isimluk
Copy link
Contributor

@isimluk isimluk commented May 2, 2023

The allowlist item has been introduced by #2928 & #2955. The item is no longer needed after chrono has been fixed on 0.4.20 in #3264.

The allowlist item has been introduced by diesel-rs#2928 & diesel-rs#2955. The item is no
longer needed after chrono has been fixed on 0.4.20 in diesel-rs#3264.
@isimluk
Copy link
Contributor Author

isimluk commented May 2, 2023

Closing for now as I have realized that 0.4.19 version of chrono is still in use.

diesel/Cargo.toml:chrono = { version = "0.4.20", optional = true, default-features = false, features = ["clock", "std"] }
diesel_cli/Cargo.toml:chrono = { version = "0.4.19", default-features = false, features = ["clock", "std"] }
diesel_tests/Cargo.toml:chrono = { version = "0.4.19", default-features = false, features = ["clock", "std"] }
examples/mysql/all_about_inserts/Cargo.toml:chrono = { version = "0.4.19", default-features = false, features = ["clock", "std"] }
examples/postgres/advanced-blog-cli/Cargo.toml:chrono = { version = "0.4.19", default-features = false, features = ["clock", "std"] }
examples/sqlite/all_about_inserts/Cargo.toml:chrono = { version = "0.4.19", default-features = false, features = ["clock", "std"] }

Sorry for the noise.

@isimluk isimluk closed this May 2, 2023
@weiznich
Copy link
Member

weiznich commented May 2, 2023

@isimluk I think it should be fine to just update the chrono version in all that crates. I would accept a PR for that.

@isimluk
Copy link
Contributor Author

isimluk commented May 2, 2023

Thanks for the confirmation, I am investigating that. I also just realized that 0.4.20 gets picked up automatically, even in cases where 0.4.19 gets spelled out.

@isimluk isimluk reopened this May 2, 2023
@weiznich weiznich enabled auto-merge May 2, 2023 16:16
@weiznich weiznich added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 2, 2023
@weiznich weiznich added this pull request to the merge queue May 2, 2023
Merged via the queue into diesel-rs:master with commit ac0629e May 2, 2023
31 checks passed
@isimluk isimluk deleted the remove-audit-allowlist branch May 4, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants