Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0159: Potential segfault in localtime_r invocations #2928

Closed
github-actions bot opened this issue Oct 22, 2021 · 3 comments
Closed

RUSTSEC-2020-0159: Potential segfault in localtime_r invocations #2928

github-actions bot opened this issue Oct 22, 2021 · 3 comments

Comments

@github-actions
Copy link

Potential segfault in localtime_r invocations

Details
Package chrono
Version 0.4.19
URL chronotope/chrono#499
Date 2020-11-10

Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

Workarounds

No workarounds are known.

References

See advisory page for additional details.

@PSeitz
Copy link

PSeitz commented Mar 29, 2022

Just wanted to add that at quickwit/tantivy we removed chrono in favor of time (https://crates.io/crates/time), since chrono is unmaintained.

quickwit-oss/tantivy#1304
quickwit-oss/quickwit#1232

@weiznich
Copy link
Member

@PSeitz We do not have any planes to remove chrono as:

  • That would be a huge breaking change for anyone using chrono and diesel (I assume there are quite a lot users out there)
  • Our API usage is not affected by this issue
  • Chrono is behind a optional feature flag, so users can choose if they want to depend on chrono or not

As for using time: I would accept a PR adding support for the corresponding time types, but I personally do not have any plan to implement that in the next weeks/months.

@Ten0
Copy link
Member

Ten0 commented Jul 7, 2022

Considering the advisory has been withdrawn (https://rustsec.org/advisories/RUSTSEC-2020-0159.html) and chrono is an opt-in we can probably close this.

@Ten0 Ten0 closed this as completed Jul 7, 2022
isimluk added a commit to isimluk/diesel that referenced this issue May 2, 2023
The allowlist item has been introduced by diesel-rs#2928 & diesel-rs#2955. The item is no
longer needed after chrono has been fixed on 0.4.20 in diesel-rs#3264.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants