Skip to content

Commit

Permalink
Bump trybuild and rustversion again to fix compile tests
Browse files Browse the repository at this point in the history
  • Loading branch information
weiznich committed Jan 10, 2023
1 parent 8a9c304 commit 6921fe2
Show file tree
Hide file tree
Showing 79 changed files with 3,568 additions and 3,439 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ jobs:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2022-11-05
toolchain: nightly-2023-01-10
- name: Cache cargo registry
uses: actions/cache@v3
with:
Expand All @@ -309,7 +309,7 @@ jobs:
- name: Run compile tests
shell: bash
run: cargo +nightly-2022-11-05 test --manifest-path diesel_compile_tests/Cargo.toml
run: cargo +nightly-2023-01-10 test --manifest-path diesel_compile_tests/Cargo.toml

rustfmt_and_clippy:
name: Check rustfmt style && run clippy
Expand Down
4 changes: 2 additions & 2 deletions diesel_compile_tests/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion diesel_compile_tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ version = "0.1.0"

[dependencies]
diesel = { version = "2.0.0", default-features = false, features = ["extras", "sqlite", "postgres", "mysql", "with-deprecated", "nightly-error-messages"], path = "../diesel" }
trybuild = "1.0.73"
trybuild = "1.0.75"

[workspace]
2 changes: 1 addition & 1 deletion diesel_compile_tests/rust-toolchain
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nightly-2022-11-05
nightly-2023-01-10
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ error[E0271]: type mismatch resolving `<users::table as AppearsInFromClause<post
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:19:31
|
19 | let source = users::table.select(sum(posts::id));
| ^^^^^^ expected struct `diesel::query_source::Never`, found struct `diesel::query_source::Once`
| ^^^^^^ expected struct `Never`, found struct `Once`
|
note: required for `posts::columns::id` to implement `AppearsOnTable<users::table>`
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:13:9
Expand Down Expand Up @@ -76,7 +76,7 @@ error[E0271]: type mismatch resolving `<users::table as AppearsInFromClause<post
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:20:31
|
20 | let source = users::table.select(avg(posts::id));
| ^^^^^^ expected struct `diesel::query_source::Never`, found struct `diesel::query_source::Once`
| ^^^^^^ expected struct `Never`, found struct `Once`
|
note: required for `posts::columns::id` to implement `AppearsOnTable<users::table>`
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:13:9
Expand Down Expand Up @@ -133,7 +133,7 @@ error[E0271]: type mismatch resolving `<users::table as AppearsInFromClause<post
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:21:31
|
21 | let source = users::table.select(max(posts::id));
| ^^^^^^ expected struct `diesel::query_source::Never`, found struct `diesel::query_source::Once`
| ^^^^^^ expected struct `Never`, found struct `Once`
|
note: required for `posts::columns::id` to implement `AppearsOnTable<users::table>`
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:13:9
Expand Down Expand Up @@ -190,7 +190,7 @@ error[E0271]: type mismatch resolving `<users::table as AppearsInFromClause<post
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:22:31
|
22 | let source = users::table.select(min(posts::id));
| ^^^^^^ expected struct `diesel::query_source::Never`, found struct `diesel::query_source::Once`
| ^^^^^^ expected struct `Never`, found struct `Once`
|
note: required for `posts::columns::id` to implement `AppearsOnTable<users::table>`
--> tests/fail/aggregate_expression_requires_column_from_same_table.rs:13:9
Expand Down
2 changes: 1 addition & 1 deletion diesel_compile_tests/tests/fail/alias_and_group_by.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ note: required for `columns::id` to implement `ValidGrouping<columns::name>`
| ^^
= note: 1 redundant requirement hidden
= note: required for `AliasedField<user1, columns::id>` to implement `ValidGrouping<AliasedField<user1, columns::name>>`
= note: required for `SelectStatement<FromClause<Alias<user1>>, diesel::query_builder::select_clause::DefaultSelectClause<FromClause<Alias<user1>>>, diesel::query_builder::distinct_clause::NoDistinctClause, diesel::query_builder::where_clause::NoWhereClause, diesel::query_builder::order_clause::NoOrderClause, diesel::query_builder::limit_offset_clause::LimitOffsetClause<diesel::query_builder::limit_clause::NoLimitClause, diesel::query_builder::offset_clause::NoOffsetClause>, diesel::query_builder::group_by_clause::GroupByClause<AliasedField<user1, columns::name>>>` to implement `SelectDsl<AliasedField<user1, columns::id>>`
= note: required for `SelectStatement<FromClause<Alias<user1>>, DefaultSelectClause<FromClause<...>>, ..., ..., ..., ..., ...>` to implement `SelectDsl<AliasedField<user1, columns::id>>`
Original file line number Diff line number Diff line change
Expand Up @@ -7,57 +7,57 @@ warning: use of deprecated function `diesel::dsl::any`: Use `ExpressionMethods::
= note: `#[warn(deprecated)]` on by default

error[E0271]: type mismatch resolving `<stuff::table as AppearsInFromClause<more_stuff::table>>::Count == diesel::query_source::Once`
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:31:15
|
31 | .load(&mut conn);
| ---- ^^^^^^^^^ expected struct `diesel::query_source::Once`, found struct `diesel::query_source::Never`
| |
| required by a bound introduced by this call
|
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:31:15
|
31 | .load(&mut conn);
| ---- ^^^^^^^^^ expected struct `Once`, found struct `Never`
| |
| required by a bound introduced by this call
|
note: required for `more_stuff::columns::names` to implement `AppearsOnTable<stuff::table>`
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:15:9
|
15 | names -> Array<VarChar>,
| ^^^^^
= note: 3 redundant requirements hidden
= note: required for `diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>` to implement `AppearsOnTable<stuff::table>`
= note: required for `diesel::query_builder::where_clause::WhereClause<diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>>` to implement `diesel::query_builder::where_clause::ValidWhereClause<FromClause<stuff::table>>`
= note: required for `SelectStatement<FromClause<stuff::table>, diesel::query_builder::select_clause::DefaultSelectClause<FromClause<stuff::table>>, diesel::query_builder::distinct_clause::NoDistinctClause, diesel::query_builder::where_clause::WhereClause<diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>>>` to implement `Query`
= note: required for `SelectStatement<FromClause<stuff::table>, diesel::query_builder::select_clause::DefaultSelectClause<FromClause<stuff::table>>, diesel::query_builder::distinct_clause::NoDistinctClause, diesel::query_builder::where_clause::WhereClause<diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>>>` to implement `LoadQuery<'_, _, _>`
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:15:9
|
15 | names -> Array<VarChar>,
| ^^^^^
= note: 3 redundant requirements hidden
= note: required for `Grouped<Eq<name, Any<names>>>` to implement `AppearsOnTable<stuff::table>`
= note: required for `WhereClause<Grouped<Eq<name, Any<names>>>>` to implement `diesel::query_builder::where_clause::ValidWhereClause<FromClause<stuff::table>>`
= note: required for `SelectStatement<FromClause<table>, DefaultSelectClause<FromClause<table>>, NoDistinctClause, WhereClause<...>>` to implement `Query`
= note: required for `SelectStatement<FromClause<table>, DefaultSelectClause<FromClause<table>>, NoDistinctClause, WhereClause<...>>` to implement `LoadQuery<'_, _, _>`
note: required by a bound in `diesel::RunQueryDsl::load`
--> $DIESEL/src/query_dsl/mod.rs
|
| Self: LoadQuery<'query, Conn, U>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `diesel::RunQueryDsl::load`
--> $DIESEL/src/query_dsl/mod.rs
|
| Self: LoadQuery<'query, Conn, U>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `RunQueryDsl::load`

error[E0277]: the trait bound `stuff::table: TableNotEqual<more_stuff::table>` is not satisfied
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:31:15
|
31 | .load(&mut conn);
| ---- ^^^^^^^^^ the trait `TableNotEqual<more_stuff::table>` is not implemented for `stuff::table`
| |
| required by a bound introduced by this call
|
= help: the following other types implement trait `TableNotEqual<T>`:
<Only<pg::metadata_lookup::pg_namespace::table> as TableNotEqual<pg::metadata_lookup::pg_type::table>>
<Only<pg::metadata_lookup::pg_type::table> as TableNotEqual<pg::metadata_lookup::pg_namespace::table>>
<pg::metadata_lookup::pg_namespace::table as TableNotEqual<Only<pg::metadata_lookup::pg_type::table>>>
<pg::metadata_lookup::pg_namespace::table as TableNotEqual<pg::metadata_lookup::pg_type::table>>
<pg::metadata_lookup::pg_type::table as TableNotEqual<Only<pg::metadata_lookup::pg_namespace::table>>>
<pg::metadata_lookup::pg_type::table as TableNotEqual<pg::metadata_lookup::pg_namespace::table>>
= note: required for `stuff::table` to implement `AppearsInFromClause<more_stuff::table>`
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:31:15
|
31 | .load(&mut conn);
| ---- ^^^^^^^^^ the trait `TableNotEqual<more_stuff::table>` is not implemented for `stuff::table`
| |
| required by a bound introduced by this call
|
= help: the following other types implement trait `TableNotEqual<T>`:
<Only<pg::metadata_lookup::pg_namespace::table> as TableNotEqual<pg::metadata_lookup::pg_type::table>>
<Only<pg::metadata_lookup::pg_type::table> as TableNotEqual<pg::metadata_lookup::pg_namespace::table>>
<pg::metadata_lookup::pg_namespace::table as TableNotEqual<Only<pg::metadata_lookup::pg_type::table>>>
<pg::metadata_lookup::pg_namespace::table as TableNotEqual<pg::metadata_lookup::pg_type::table>>
<pg::metadata_lookup::pg_type::table as TableNotEqual<Only<pg::metadata_lookup::pg_namespace::table>>>
<pg::metadata_lookup::pg_type::table as TableNotEqual<pg::metadata_lookup::pg_namespace::table>>
= note: required for `stuff::table` to implement `AppearsInFromClause<more_stuff::table>`
note: required for `more_stuff::columns::names` to implement `AppearsOnTable<stuff::table>`
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:15:9
|
15 | names -> Array<VarChar>,
| ^^^^^
= note: 3 redundant requirements hidden
= note: required for `diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>` to implement `AppearsOnTable<stuff::table>`
= note: required for `diesel::query_builder::where_clause::WhereClause<diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>>` to implement `diesel::query_builder::where_clause::ValidWhereClause<FromClause<stuff::table>>`
= note: required for `SelectStatement<FromClause<stuff::table>, diesel::query_builder::select_clause::DefaultSelectClause<FromClause<stuff::table>>, diesel::query_builder::distinct_clause::NoDistinctClause, diesel::query_builder::where_clause::WhereClause<diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>>>` to implement `Query`
= note: required for `SelectStatement<FromClause<stuff::table>, diesel::query_builder::select_clause::DefaultSelectClause<FromClause<stuff::table>>, diesel::query_builder::distinct_clause::NoDistinctClause, diesel::query_builder::where_clause::WhereClause<diesel::expression::grouped::Grouped<diesel::expression::operators::Eq<stuff::columns::name, diesel::pg::expression::array_comparison::Any<more_stuff::columns::names>>>>>` to implement `LoadQuery<'_, _, _>`
--> tests/fail/any_is_only_selectable_if_inner_expr_is_selectable.rs:15:9
|
15 | names -> Array<VarChar>,
| ^^^^^
= note: 3 redundant requirements hidden
= note: required for `Grouped<Eq<name, Any<names>>>` to implement `AppearsOnTable<stuff::table>`
= note: required for `WhereClause<Grouped<Eq<name, Any<names>>>>` to implement `diesel::query_builder::where_clause::ValidWhereClause<FromClause<stuff::table>>`
= note: required for `SelectStatement<FromClause<table>, DefaultSelectClause<FromClause<table>>, NoDistinctClause, WhereClause<...>>` to implement `Query`
= note: required for `SelectStatement<FromClause<table>, DefaultSelectClause<FromClause<table>>, NoDistinctClause, WhereClause<...>>` to implement `LoadQuery<'_, _, _>`
note: required by a bound in `diesel::RunQueryDsl::load`
--> $DIESEL/src/query_dsl/mod.rs
|
| Self: LoadQuery<'query, Conn, U>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `diesel::RunQueryDsl::load`
--> $DIESEL/src/query_dsl/mod.rs
|
| Self: LoadQuery<'query, Conn, U>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `RunQueryDsl::load`

0 comments on commit 6921fe2

Please sign in to comment.