Apparently, it’s possible to receive ipv6 without port.

didip · Nov 18, 2017 · b65680a · b65680a
1 parent f2c85b5
commit b65680a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/libstring/libstring.go b/libstring/libstring.go
@@ -24,7 +24,12 @@ func RemoteIP(ipLookups []string, forwardedForIndexFromBehind int, r *http.Reque
 
 	for _, lookup := range ipLookups {
 		if lookup == "RemoteAddr" {
-			ip, _, _ := net.SplitHostPort(r.RemoteAddr)
+			// 1. Cover the basic use cases for both ipv4 and ipv6
+			ip, _, err := net.SplitHostPort(r.RemoteAddr)
+			if err != nil {
+				// 2. Upon error, just return the remote addr.
+				return r.RemoteAddr
+			}
 			return ip
 		}
 		if lookup == "X-Forwarded-For" && forwardedFor != "" {