Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] use pyproject.toml and setup.cfg instead of setup.py #83

Merged
merged 36 commits into from
Jan 31, 2021
Merged

Conversation

ctb
Copy link
Member

@ctb ctb commented Jan 23, 2021

Many minor changes and configuration updates to bring the project up to date.

  • create a pyproject.toml
  • switch away from setup.py to using setup.cfg
  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality, is it tested?
  • make format diff_pylint_report doc Is it well formatted?
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Member Author

ctb commented Jan 23, 2021

@luizirber if you have a chance to look at this, I'm curious as to why python setup.py dist doesn't recognize the version from setuptools_scm. python -m build seems to, though.

@ctb
Copy link
Member Author

ctb commented Jan 23, 2021

figured it out! I needed

[options]
setup_requires =
  setuptools_scm

added in f5f1a52

@ctb
Copy link
Member Author

ctb commented Jan 23, 2021

I think the only things left are -

  • try out the pypi upload on the testing site
  • check manifest/file inclusion, and/or examine old files to make sure I transferred info over correctly

@ctb ctb changed the base branch from latest to update_code January 23, 2021 16:05
@ctb ctb changed the base branch from update_code to use_setuptools_scm January 23, 2021 16:20
@ctb ctb changed the title misc updates including refiguring python project config [WIP] use pyproject.toml and setup.cfg instead of setup.py Jan 23, 2021
@ctb ctb changed the base branch from use_setuptools_scm to latest January 23, 2021 16:30
@ctb ctb changed the title [WIP] use pyproject.toml and setup.cfg instead of setup.py [MRG] use pyproject.toml and setup.cfg instead of setup.py Jan 29, 2021
@ctb
Copy link
Member Author

ctb commented Jan 29, 2021

I think this is ready for review @luizirber - I'm new to these files, so advice/suggestions requested!!

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
@ctb
Copy link
Member Author

ctb commented Jan 29, 2021

all fixed, all tests pass!

@luizirber
Copy link
Member

The tests are indeed passing, but... CI is not testing anything 🤣

I think it was missing the tox-gh-actions configs in tox.ini, let's see

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #83 (1e24347) into latest (2303f66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           latest      #83   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files          15       15           
  Lines         633      633           
=======================================
  Hits          554      554           
  Misses         79       79           
Impacted Files Coverage Δ
screed/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2303f66...1e24347. Read the comment docs.

@luizirber
Copy link
Member

Some tox fixes would be nice too, but now it's failing because of pep8 🙃

@ctb
Copy link
Member Author

ctb commented Jan 30, 2021

The tests are indeed passing, but... CI is not testing anything 🤣

oops :)

@ctb
Copy link
Member Author

ctb commented Jan 30, 2021

ok @luizirber how does this look?

@luizirber
Copy link
Member

Looking good! There is a curious warning showing up, but not a merge blocker

@ctb
Copy link
Member Author

ctb commented Jan 31, 2021

is this the warning, @luizirber?

DeprecationWarning: Creating a LegacyVersion has been deprecated and will be removed in the next major release,

if so, see: pypa/pip#9250 and links therein. It's a pip thing.

@ctb ctb merged commit c90069d into latest Jan 31, 2021
@ctb ctb deleted the update_py branch January 31, 2021 15:05
@ctb ctb restored the update_py branch January 31, 2021 15:05
@dib-lab dib-lab deleted a comment from hugovk Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants