-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] use pyproject.toml and setup.cfg instead of setup.py #83
Conversation
@luizirber if you have a chance to look at this, I'm curious as to why |
figured it out! I needed
added in f5f1a52 |
I think the only things left are -
|
I think this is ready for review @luizirber - I'm new to these files, so advice/suggestions requested!! |
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
all fixed, all tests pass! |
The tests are indeed passing, but... CI is not testing anything 🤣 I think it was missing the |
Codecov Report
@@ Coverage Diff @@
## latest #83 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 15 15
Lines 633 633
=======================================
Hits 554 554
Misses 79 79
Continue to review full report at Codecov.
|
Some tox fixes would be nice too, but now it's failing because of |
oops :) |
ok @luizirber how does this look? |
Looking good! There is a curious warning showing up, but not a merge blocker |
is this the warning, @luizirber?
if so, see: pypa/pip#9250 and links therein. It's a pip thing. |
Many minor changes and configuration updates to bring the project up to date.
pyproject.toml
setup.py
to usingsetup.cfg
make test
Did it pass the tests?make clean diff-cover
If it introduces new functionality, is it tested?make format diff_pylint_report doc
Is it well formatted?documented in
CHANGELOG.md
? See keepachangelogfor more details.
changes were made?