add API routes for comment likes #8439
Merged
+341
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jhass
force-pushed
the
feature/comment_likes_api
branch
from
627c067
to
1e1130e
Compare
SuperTux88
requested changes
Jun 2, 2024
Comment on lines
123
to
143
| def comment_and_post_validate(post_guid, comment_guid) | ||
| if !comment_exists(comment_guid) || !comment_is_for_post(post_guid, comment_guid) | ||
| render_error 404, "Comment not found for the given post" | ||
| false | ||
| else | ||
| true | ||
| end | ||
| end | ||
|
|
||
| def comment_exists(comment_guid) | ||
| comment = comment_service.find!(comment_guid) | ||
| comment ? true : false | ||
| rescue ActiveRecord::RecordNotFound | ||
| false | ||
| end | ||
|
|
||
| def comment_is_for_post(post_guid, comment_guid) | ||
| comments = comment_service.find_for_post(post_guid) | ||
| comment = comments.find {|comment| comment[:guid] == comment_guid } | ||
| comment ? true : false | ||
| end |
There was a problem hiding this comment.
The comment_exists is kinda redundant, if the comment doesn't exist, it also doesn't exist "for the post", so only checking comment_is_for_post is enough.
Also in comment_is_for_post you can use .exists? directly on an SQL level, instead of looping through all comments with find.
Like this:
Suggested change
| def comment_and_post_validate(post_guid, comment_guid) | |
| if !comment_exists(comment_guid) || !comment_is_for_post(post_guid, comment_guid) | |
| render_error 404, "Comment not found for the given post" | |
| false | |
| else | |
| true | |
| end | |
| end | |
| def comment_exists(comment_guid) | |
| comment = comment_service.find!(comment_guid) | |
| comment ? true : false | |
| rescue ActiveRecord::RecordNotFound | |
| false | |
| end | |
| def comment_is_for_post(post_guid, comment_guid) | |
| comments = comment_service.find_for_post(post_guid) | |
| comment = comments.find {|comment| comment[:guid] == comment_guid } | |
| comment ? true : false | |
| end | |
| def comment_and_post_validate(post_guid, comment_guid) | |
| if comment_is_for_post(post_guid, comment_guid) | |
| true | |
| else | |
| render_error 404, "Comment not found for the given post" | |
| false | |
| end | |
| end | |
| def comment_is_for_post(post_guid, comment_guid) | |
| comments = comment_service.find_for_post(post_guid) | |
| comments.exists?(guid: comment_guid) | |
| end |
This way the whole validation is just a single sql-query, instead of 2 queries and looping through all comments in ruby.
It's enough to check if the comment exists on the specified post, if it doesn't exist at all, that check will also fail. Also do that check directly on SQL level and just check if the comment exist instead of looping through all comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.