-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for 3rd party s3-compatible object storage #7244
base: develop
Are you sure you want to change the base?
Conversation
Does the |
AFAIK it should still work, it just accesses the bucket by an alternate method. Someone with an s3 account should probably verify though. |
I appears that AssetSync isn't so easy to override the defaults on, so while this patch makes uploads work, assets still try to go to s3. |
What I meant with my comment above was: Is the |
Just uploads, I think. Doesn't D* get the url path from configuration > assets > host? |
I think Also, if this PR doesn't work with AssetSync, we should add a comment somewhere, that you couldn't enable asset upload if you change the S3 host. And probably also add a check that it only enables when the |
Yes, I believe it does change the urls from 'bucket.example.com' to 'example.com/bucket', but AFAIK Amazon supports both styles. Would you like me to add comments and resubmit, or do you want that done on your end? |
I think we should expose this option in the config then and use the previous behavior as default.
Please add a comment and also add a check that blocks if someone tries to enable asset upload with a changed S3 host. You can also print a warning then. |
Ok. What's the best way to deal with that? Throw an exception? |
I think so, because it wouldn't work anyway. |
I'm researching this topic to potentially pick it up. Looking at the documentation for Fog it seems that the credentials is highly system dependent. I'm surprised the Minio thing worked but perhaps since it is S3-compatible it's just taking the same access key/secret/region pairs and "just works". In the Fogs library the logins for Digital Ocean and GCS are different, and in the CarrierWave source code it actually shows the different credentials for GCS and Rackspace. We'll have to look at this more carefully. |
I added these comments to the Discourse forum as well but want to capture here:
|
@HankG How's the progress on this, are you still planning on getting this work in? :) |
Bump on conflicting files |
In regards to issue #7243, I was able to modify the carrierwave settings to enable my pod to use minio as an s3 backend. For some reason using the 'bucketname.example.com' form of uploading was throwing an SSLv3 error, so I had to enable
:path_style = true
to get around this, which uses 'example.com/bucketname' instead.