Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Zend_Db_Table_Rowset docblocks with generics to allow better type hinting #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomasfejfar
Copy link
Contributor

This is a PoC, that's still somewhat limited due to phpstan/phpstan#5817 but I got the rest working in tomasfejfar/phpstan-zf1#2.

Do you like the way this is heading? I wonder if this is the right way and wanted to get some feedback early.

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #116 (460f49f) into master (17293b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #116   +/-   ##
=========================================
  Coverage     55.26%   55.26%           
  Complexity     1722     1722           
=========================================
  Files            42       42           
  Lines          4706     4706           
=========================================
  Hits           2601     2601           
  Misses         2105     2105           
Impacted Files Coverage Δ
src/Zend/Db/Table/Rowset/Abstract.php 97.87% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17293b7...460f49f. Read the comment docs.

@jaydiablo
Copy link
Member

@tomasfejfar we actually don't use the Zend_Db component in our apps, so I don't think I'm the best person to get feedback from on this :)

I'm open to merging changes once you're happy with it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants