Feature work with husky (#47) #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(githook.ts): add support for git core hooks path and fallback to default symlink url if not found feat(utils/git.ts): add getCoreHooksPath function to retrieve the path of the core hooks directory.
|
Pull request for #47 |
AdrielBento
reviewed
Mar 23, 2023
|
Noticing some undesired behavior will need another commit to fix |
|
changed base branch to dev |
di-sukharev
approved these changes
Mar 24, 2023
|
@matt-degraffenreid bro, awesome PR, let's merge when you solve the conflicts :) |
|
@matt-degraffenreid bro, could you also add this fix for windows #11 (comment) |
…pareCommitMessageHook function to stage all changes if flag is true
|
Fixed the issue I had with behavior there was a flag missing from the hook process causing all files to get staged. Copy and pasted the code from the commit process to make the flag. Will take a look at number #11 and fix the merge conflicts |
…string concatenation style(githook.ts): format code with prettier
|
Resolved the conflicts, and addressed #11. Just need a reviewer and this one is good to merge into dev |
|
@matt-degraffenreid bro, solve the conflicts pls and i will merge it |
|
Making a new pull request fubared this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(githook.ts): add support for git core hooks path and fallback to default symlink url if not found
feat(utils/git.ts): add getCoreHooksPath function to retrieve the path of the core hooks directory.