Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

chore(cypress npm scripts): replace scripts with concurrently & wait-on #154

Merged
merged 5 commits into from Oct 25, 2019

Conversation

Mohammer5
Copy link
Contributor

@Mohammer5 Mohammer5 commented Oct 18, 2019

Thanks to @amcgee I was able to get rid of the scripts folder and do everything with concurrently and wait-on

I've also refactored the feature and spec files to match the feature / scenario descriptions

@Mohammer5 Mohammer5 requested review from varl and a team as code owners October 18, 2019 01:22
@netlify
Copy link

netlify bot commented Oct 18, 2019

Deploy preview for dhis2-ui-widgets ready!

Built with commit 8594159

https://deploy-preview-154--dhis2-ui-widgets.netlify.com

Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked deeply into how Cypress works but this runs and looks OK until we have our "standard functional testing library".

@Mohammer5 Mohammer5 force-pushed the Concurrently_storybook_cypress branch from a57f143 to 99f3968 Compare October 24, 2019 08:11
@Mohammer5 Mohammer5 force-pushed the Concurrently_storybook_cypress branch from 99f3968 to 8594159 Compare October 25, 2019 06:13
@Mohammer5 Mohammer5 merged commit 4773b30 into master Oct 25, 2019
@Mohammer5 Mohammer5 deleted the Concurrently_storybook_cypress branch October 25, 2019 06:24
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants