feat: autoregister commands & add enableAutoLogin setup #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammer5
force-pushed
the
CLI-14_Autoregister_commands
branch
from
33d7a6d
to
5b226ed
Compare
Mohammer5
force-pushed
the
CLI-14_Autoregister_commands
branch
from
5b226ed
to
d784580
Compare
Mohammer5
changed the title
paschalidi
reviewed
Nov 19, 2020
packages/cypress-commands/src/commands/fillAndSubmitLoginForm.js
Outdated
Show resolved
Hide resolved
Mohammer5
force-pushed
the
CLI-14_Autoregister_commands
branch
from
d784580
to
ac373b0
Compare
Mohammer5
commented
Nov 23, 2020
HendrikThePendric
requested changes
Nov 24, 2020
There was a problem hiding this comment.
This will be very handy, great work! I've left a few comments in the code, most relate to the same thing so I'll also try to explain my general ideas below:
- In my opinion, if possible, we should only have one
logincommand and ideally this should be doing what is nowloginBasicAuth, since that is independent of the app-platform login modal. - And besides that
logincommand we should have theenableAutoLoginsetup, which callscy.login()in thebeforehook and in thebeforeEachit preserves the cookie and localStorage item. Probably I would prefer a slightly different name, i.e.enablePersistedSessionor sth.
packages/cypress-commands/src/commands/fillAndSubmitLoginForm.js
Outdated
Show resolved
Hide resolved
|
@HendrikThePendric I've updated the login command, the setup file and the deprecation warning |
Mohammer5
force-pushed
the
CLI-14_Autoregister_commands
branch
from
d85e954
to
60cd25b
Compare
HendrikThePendric
approved these changes
Nov 25, 2020
Mohammer5
force-pushed
the
CLI-14_Autoregister_commands
branch
from
09bdb04
to
0bbb8e9
Compare
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CLI-14
enableAutoLoginsetup helperfeat(login): add command to fill login form) is a bit questionable