feat(eslint): add i18n eslint plugin #362
Conversation
config/js/eslint-react.config.js
Outdated
| @@ -14,6 +16,10 @@ module.exports = { | |||
| }, | |||
|
|
|||
| rules: { | |||
| 'i18next/no-literal-string': [ | |||
| 'warn', | |||
| { markupOnly: true, onlyAttribute: [''] }, | |||
There was a problem hiding this comment.
Perhaps we could change this so that label and displayName attributes would require i18n?
There was a problem hiding this comment.
Yeah I could do that. Is it necessary to translate displayName though? That's only for developers right?
There was a problem hiding this comment.
I've enabled it for label in 4e5acac. I've not enabled it for displayName as that's only used in error messages and not user facing.
There was a problem hiding this comment.
Enabling it for label has the expected result, so seems like a good addition:
This comment has been minimized.
This comment has been minimized.
|
Hi! Due to a lack of activity on this issue over time (180 days) it seems to be stale. If still relevant, please provide information that moves it forward, e.g. additional information, a pull request with suggested changes, or a reason to keep it open. Any activity will keep it open, otherwise it will be closed automatically in 30 days. Thanks! 🤖 |
|
Automatically closing due to lack of activity. 🤖 |
See this slack thread: https://dhis2.slack.com/archives/CPGUFVC56/p1615363540343500
This adds https://github.com/edvardchen/eslint-plugin-i18next, which warns on untranslated strings in jsx. The settings are what I've been using in the scheduler. We could tweak them a bit more later on, and for example add linting of certain attributes as well. I'm ignoring this rule for test files, as react components defined in test files won't be shipped to the end user.
I've set it to warn initially so that it's not a breaking change and to allow us to try it out first. Once we're happy with it we could move it to error and fine-tune the rule.