Disable mmap size check on arm arch as well as arm64 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requilence
requested review from
joshua-goldstein,
mangalaman93,
harshil-goel and
all-seeing-code
as code owners
This was referenced Feb 6, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #281 mmap size check has been disabled for the ARM64 arch.
But we at anytype quite often face the same problem on the arm arch on Android devices (armeabi-v7a target) with the latest badger v4.2.0 and latest ristretto v0.1.1.
memtables error: while opening fid: 1 error: while updating skiplist error: mremap size mismatch: requested: 1479692 got: 67108864This PR extends the #281 to cover all arm architectures.
Here is one more mention of this issue
dgraph-io/badger#2027 (comment)
It would also make sense to create the PR on top of v0.1.1 release, but there is not release branch to base on