-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for custom headers #32
base: master
Are you sure you want to change the base?
Conversation
Fixed unhandled case - setAlphaAuthToken called without loging in.
@@ -55,7 +55,7 @@ export class DgraphClientStub { | |||
} | |||
|
|||
this.options = options; | |||
|
|||
this.options.header = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would erase options.headers
if it exists.
Something that clients may rely on, e.g. Ratel
if (this.options.headers === undefined) {
this.options.headers = {};
}
would be much safer and backwards compatible
|
Added support for adding custom headers after creating a ClientStub object.
Reason
To be able to add headers such as auth tokens from third party authentication services that may not necessarily be available at the time of creation of the ClientStub and Client object.
This change is