Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll statefulsets on configmap updates #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t3mi
Copy link

@t3mi t3mi commented Mar 28, 2023

This adds annotations for pod spec in statefulset for automatic rollout on config map updates per helm tip.

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023

CLA assistant check
All committers have signed the CLA.

@darkn3rd
Copy link
Contributor

darkn3rd commented Apr 20, 2023

@t3mi I tested this PR and found that the solution does not work, likely because the mount paths and file names are incorrect, i.e. /alpha/configs.yaml and /zero/configs.yaml.

If you would like to update this, the following items are needed:

  • the mount path is /dgraph/config
  • the file name can be json or yaml, depending what the user has for the key of alpha.configFile[0] and zero.configFile[0].
  • there needs to be a boolean, e.g. alpha.configChecksum: true that enables or disables this feature.

I ran the following tests to test this feature:

git clone git@github.com:dgraph-io/charts.git && pushd charts && gh pr checkout 85 && popd
helm install t1 ./charts/charts/dgraph
helm upgrade t1 \
 --values ./charts/charts/dgraph/example_values/alpha-acl-secrets.yaml \
 --values  ./charts/charts/dgraph/example_values/alpha-acl-config.yaml \
 ./charts/charts/dgraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants