Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): Update to pull_request trigger #2056

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(CI): Update to pull_request trigger #2056

merged 1 commit into from
Apr 8, 2024

Conversation

ryanfoxtyler
Copy link
Contributor

Problem

Using pull_request_target can expose secrets based on a quirk in how GitHub applies permissions to forks. See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Solution

Change trigger from pull_request_target to pull_request

@ryanfoxtyler ryanfoxtyler requested a review from a team as a code owner April 8, 2024 13:05
@netlify Netlify
Copy link

netlify bot commented Apr 8, 2024 •
edited

✅ Deploy Preview for badger-docs canceled.

Name Link
🔨 Latest commit 4837995
🔍 Latest deploy log https://app.netlify.com/sites/badger-docs/deploys/6613ebabd19dbd0008369c51

@ryanfoxtyler ryanfoxtyler merged commit fece30f into main Apr 8, 2024
12 checks passed
@ryanfoxtyler ryanfoxtyler deleted the rft-ci-update branch April 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanfoxtyler @harshil-goel