fix(table): replace unrecoverable panic with error #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AveralS
requested review from
akon-dey,
billprovince,
joshua-goldstein and
skrdgraph
as code owners
|
|
mangalaman93
previously approved these changes
Oct 13, 2023
|
@AveralS Thanks for the PR. Could you please sign the CLA? |
No, i dont see accept button here 
|
|
That's pretty odd. You could try a different browser. |
table/table.go
Outdated
| @@ -343,14 +343,14 @@ func OpenInMemoryTable(data []byte, id uint64, opt *Options) (*Table, error) { | |||
| return t, nil | |||
| } | |||
|
|
|||
| func (t *Table) initBiggestAndSmallest() error { | |||
| func (t *Table) initBiggestAndSmallest() (err error) { | |||
There was a problem hiding this comment.
Can you remove the named return variable?
✅ Deploy Preview for badger-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I am using badger to store some temporary transactional data. My database crashed due to power failure and when the app starts again it panics due to the broken badger database. I can't handle this panic, because it is called in a separate goroutine.
Solution
initBiggestAndSmallest method should return an error when recovering from underlying panic.