Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v3.2103: bring fixes from master #1753

Merged
merged 5 commits into from Oct 7, 2021
Merged

release/v3.2103: bring fixes from master #1753

merged 5 commits into from Oct 7, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Oct 5, 2021 •
edited by manishrjain

manishrjain and others added 4 commits October 5, 2021 14:26
@manishrjain @NamanJain8
Fix(levels): Avoid a deadlock when acquiring read locks in levels (#1744
0c13869 
)

(cherry picked from commit 560e319)
@jalseth @NamanJain8
deps: Bump github.com/google/flatbuffers to v1.12.1 (#1746)
644971a 
The v1.12.0 version of the flatbuffers package has an issue where the
hash of the package will differ depending on if you fetch the source
using the default, public Go Modules proxy or if you fetch the source
directly, which can cause build issues [1][2]. The flatbuffers maintainers
released v1.12.1 to fix this issue [3].

[1] https://github.com/open-policy-agent/conftest/runs/3576130950?check_suite_focus=true
[2] open-policy-agent/conftest#613
[3] google/flatbuffers#6466

Signed-off-by: James Alseth <james@jalseth.me>
(cherry picked from commit a6bf4fd)
@NamanJain8
fix(builder): put the upper limit on reallocation (#1748)
4298c58 
z.Allocator imposes an upper bound of 1GB on the size of the allocator. In builder, we double the allocation while reallocating to amortize the cost over the future allocations.

Consider a scenario where the size of KV is 700MB. The size of the allocator would be 700MB. Now we want to finish the block, so we will need some bytes for the metadata. That can easily fit into the remaining 324MB. But we were earlier doing over-allocation that causes panic.

(cherry picked from commit f762055)
@NamanJain8
fix(compact): close vlog after the compaction at L0 has completed (#1752
09a6157 
)

Vlog needs to stay open while the compaction is being run. With the CompactL0OnClose option, it becomes necessary to close the vlog after all the compactions have been completed.

(cherry picked from commit cba20b9)
@NamanJain8 NamanJain8 merged commit f388e91 into release/v3.2103 Oct 7, 2021
@joshua-goldstein joshua-goldstein deleted the naman/master-to-2103 branch October 12, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NamanJain8 @ahsanbarkati @manishrjain @jalseth