Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HMAC-SHA1 key creation. #72

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Fix HMAC-SHA1 key creation. #72

merged 1 commit into from
Aug 27, 2023

Commits on Jun 7, 2023

  1. Fix HMAC-SHA1 key creation. 

    Per the OAuth 1.0 spec (https://oauth.net/core/1.0a/#anchor15), the consumer secret and the tokenSecret both need to be parameter-encoded before being concatenated with the "&". This change performs this encoding with PercentEncode().

Without this change, OAuth would fail for services that include special characters in either the Consumer secret or the Request Token secret, but would succeed for services that did not. Specifically, this fix allows this library to be used with the etrade API, which does include special characters in the Request Token secret.
    @jerryryle
    jerryryle committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9da7970 View commit details
    Browse the repository at this point in the history