Read body of error response #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a failing request to retrieve a request token or an access token with an unexpected status code was hard to debug, because additional information returned by the server in the body of the response was inaccessible to the user of this library. This patch changes that by including the body in the error message. Since the body is now read before the potential status code error is returned, but it is crucial information for debugging, we also include the status code in an error resulting from reading the body.
fdcds
commented
Aug 23, 2021
|
Added via #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a failing request to retrieve a request token or an access token with an unexpected status code was hard to debug, because additional information returned by the server in the body of the response was inaccessible to the user of this library.
This patch changes that by including the body in the error message. Since the body is now read before the potential status code error is returned, but it is crucial information for debugging, we also include the status code in an error resulting from reading the body.