Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override the http.Client for RequestToken and AccessToken #49

Merged
merged 3 commits into from Jun 9, 2021
Merged

Allow to override the http.Client for RequestToken and AccessToken #49

merged 3 commits into from Jun 9, 2021

Commits on May 17, 2021

  1. Allow to override the http.Client for RequestToken and AccessToken 

    Before, the `http.DefaultClient` was always used.  This is e.g. not
sufficient, if the server being authenticated against uses TLS
certificates signed by a custom root CA.  In this case, a custom
`http.Client` needs to be passed.

This change follows the design of https://github.com/golang/oauth2
and allows passing the HTTP client via `context.Context`.

Since the user of a function that accepts a `context.Context` would
likely expect it also to be used for HTTP calls, we also pass it to
`http.NewRequest`.
    @fdcds
    fdcds committed May 17, 2021
    Copy the full SHA
    75b456f View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Transport the override http.Client via Config struct instead of context

    @fdcds
    fdcds committed May 18, 2021
    Copy the full SHA
    37256b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Merge branch 'master' into ds/allow-override-httpclient

    @dghubble
    dghubble committed Jun 9, 2021
    Copy the full SHA
    2fdf403 View commit details
    Browse the repository at this point in the history