fix: allow using alternative stream handlers (Infection) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarlovi
force-pushed
the
fix/infection
branch
from
33af2bf
to
d2b4524
Compare
|
Never mind, I've just noticed master branch contains the fix mentioned by @dg and it works even without the patch made by @maks-rafalko. The fix here seems to be to rely on |
|
Should be reopened, see #9 (comment) |
|
Is it possible to make testcase? |
|
Agreed, we should try to make one to avoid regressions here. Maybe we register a dummy stream wrapper and then register BypassFinals, would that work? |
dg
force-pushed
the
master
branch
7 times, most recently
from
6dbc4f5
to
4fa5cfb
Compare
|
Alternative fix by @dg merged, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR from comments made by @dg and @maks-rafalko in #9. It's confirmed to fix issues with using Infection and BypassFinals together, tested on two of my projects.