Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Di phasemanager phaseconfigprovider #11

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

dfreilich
Copy link
Owner

Summary

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

natalieparellano and others added 12 commits March 9, 2020 16:38
Signed-off-by: Simon Jones <sijones@pivotal.io>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Fix wrong binds assertion

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Pass repo name when creating the lifecycle to avoid clobbering the one used for phase_test

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
cd tools; richgo install golang.org/x/tools/cmd/goimports
> Verifying format...
> Installing golangci-lint...
cd tools; richgo install github.com/golangci/golangci-lint/cmd/golangci-lint
> Linting code...

Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants