Run CI on visionOS #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 11 11
Lines 538 538
=======================================
Hits 533 533
Misses 5 5 |
dfed
commented
Jan 31, 2024
dfed
commented
Jan 31, 2024
| @@ -130,7 +131,7 @@ jobs: | |||
| - name: Bundle Install | |||
| run: bundle install | |||
| - name: Select Xcode Version | |||
| run: sudo xcode-select --switch /Applications/Xcode_15.0.1.app/Contents/Developer | |||
There was a problem hiding this comment.
while 15.0.1 is supported by the macOS 14 machines, I've seen a ton of spurious failures on those machines so I'm bumping to 15.2 for better support
dfed
commented
Jan 31, 2024
| s.license = 'Apache License, Version 2.0' | ||
| s.summary = 'A performant cache for logging systems. CacheAdvance persists log events 30x faster than SQLite.' | ||
| s.homepage = 'https://github.com/dfed/CacheAdvance' | ||
| s.authors = 'Dan Federman' | ||
| s.source = { :git => 'https://github.com/dfed/CacheAdvance.git', :tag => s.version } | ||
| s.swift_version = '5.6' |
There was a problem hiding this comment.
We compile on Swift 5.6, 5.7, 5.8, and 5.9. To validate that we work on visionOS, we have to lint on Swift 5.9, which we can't do if our podspec specifies an earlier source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.