feat:Add support for Public OIDC Providers #3195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add S256 verification support to the OIDC connector. Signed-off-by: Cameron Brunner <brunner@altair.com>
Remove the cached verifier after one successful lookup. Signed-off-by: Cameron Brunner <brunner@altair.com>
cameronbrunner
force-pushed
the
oidc-public
branch
from
4cca18c
to
e7889c4
Compare
cameronbrunner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add S256 verification support to the OIDC connector.
Overview
This implementation is a concrete solution to what I reported in issue #3194. It adds a new mode to the OIDC connector allowing Dex to operated as an OAuth2 'Public Application' secured by a S256 PKCE verifier.
What this PR does / why we need it
This change increases the use cases Dex can address. With Public Application support Dex can support a configuration that has no secrets and can be reused across multiple instances of a given application.
Special notes for your reviewer
I think the biggest question regarding the PR is the cache choice and behavior.
Does this PR introduce a user-facing change?
Yes. Configuration options in the OIDC connector.