fix(client): error out when opening a new tab fails

devoto13 · Apr 19, 2022 · 099b85e · 099b85e
1 parent b659015
commit 099b85e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/client/karma.js b/client/karma.js
@@ -94,6 +94,9 @@ function Karma (updater, socket, iframe, opener, navigator, location, document)
           childWindow.close()
         }
         childWindow = opener(url)
+        if (childWindow === null) {
+          self.error('Opening a new tab/window failed, probably because pop-ups are blocked.')
+        }
       // run context on parent element (client_with_context)
       // using window.__karma__.scriptUrls to get the html element strings and load them dynamically
       } else if (url !== 'about:blank') {

diff --git a/static/karma.js b/static/karma.js
@@ -104,6 +104,9 @@ function Karma (updater, socket, iframe, opener, navigator, location, document)
           childWindow.close()
         }
         childWindow = opener(url)
+        if (childWindow === null) {
+          self.error('Opening a new tab/window failed, probably because pop-ups are blocked.')
+        }
       // run context on parent element (client_with_context)
       // using window.__karma__.scriptUrls to get the html element strings and load them dynamically
       } else if (url !== 'about:blank') {