mock.Protected().Setup<int>("Foo") fails base implementation of Foo is hidden in the derived class #1342

VladimirKhvostov · 2023-05-10T02:11:04Z

This PR fixes an issue described in the #1341

CLAassistant · 2023-05-10T02:11:10Z

All committers have signed the CLA.

…s hidden in the derived class (devlooped#1341)

kzu · 2023-08-04T19:44:43Z

Thanks for the PR! Could you rebase on top of main, since files moved around?

stakx

I haven't reviewed & tested this in detail TBH, but it generally looks good to me.

The changelog should be first updated with the latest few missing releases though, otherwise the changelog entry will end up with an incorrect (already published) version.

CHANGELOG.md

mock.Protected().Setup<int>("Foo") fails base implementation of Foo i…

de41b2b

…s hidden in the derived class (devlooped#1341)

VladimirKhvostov force-pushed the main branch from 74d2528 to de41b2b Compare May 10, 2023 02:12

stakx reviewed Aug 17, 2023

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mock.Protected().Setup<int>("Foo") fails base implementation of Foo is hidden in the derived class #1342

mock.Protected().Setup<int>("Foo") fails base implementation of Foo is hidden in the derived class #1342

VladimirKhvostov commented May 10, 2023

CLAassistant commented May 10, 2023 •

edited

kzu commented Aug 4, 2023

stakx left a comment

mock.Protected().Setup<int>("Foo") fails base implementation of Foo is hidden in the derived class #1342

Are you sure you want to change the base?

mock.Protected().Setup<int>("Foo") fails base implementation of Foo is hidden in the derived class #1342

Conversation

VladimirKhvostov commented May 10, 2023

CLAassistant commented May 10, 2023 • edited

kzu commented Aug 4, 2023

stakx left a comment

Choose a reason for hiding this comment

CLAassistant commented May 10, 2023 •

edited