Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StubbedPropertySetup.IsMatch less picky #1260

Merged
merged 3 commits into from May 12, 2022
Merged

Make StubbedPropertySetup.IsMatch less picky #1260

merged 3 commits into from May 12, 2022

Commits on May 12, 2022

  1. Add regression test for SetupProperty

    @stakx
    stakx committed May 12, 2022
    Copy the full SHA
    8f69c60 View commit details
    Browse the repository at this point in the history

  2. StubbedPropertySetup.IsMatch is too picky 

    Comparing `MethodInfo`s using the `==` operator appears to go wrong more
often than not. (In this case, this method fails to identify a positive
match of `Base.Property` as the implementation for `IBase.Property`).

Let's make this test much more imprecise by simply comparing accessor
method names (and thus completely ignoring the type hierarchy; if we're
lucky, the .NET compilers will already guarantee valid polymorphic type
relationships).
    @stakx
    stakx committed May 12, 2022
    Copy the full SHA
    2c14374 View commit details
    Browse the repository at this point in the history

  3. Update the changelog

    @stakx
    stakx committed May 12, 2022
    Copy the full SHA
    7a7a76b View commit details
    Browse the repository at this point in the history