Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html templating+css extraction #10

Merged
merged 10 commits into from May 3, 2020
Merged

Conversation

devlinjunker
Copy link
Owner

@devlinjunker devlinjunker commented May 1, 2020

Description

Figure out HTML Templating with underscore loader
CSS Extraction with mini-css-extract-plugin

Had to update karma-webpack to v4 to fix issue with running tests/karma after adding mini-css-extract-plugin: codymikol/karma-webpack#394 (comment)

Related

N/A

Visual

CSS Files rather than inline style:
Screenshot 2020-05-01 09 41 59

Templating with Header on both pages:
Screenshot 2020-05-01 09 42 12

TODO

  • PR Body
  • Updated READMEs

@devlinjunker devlinjunker force-pushed the html-templating+css-extraction branch from ba49ba0 to 0987122 Compare May 1, 2020 15:25
@devlinjunker devlinjunker force-pushed the html-templating+css-extraction branch from 0987122 to d282558 Compare May 1, 2020 16:11
@devlinjunker devlinjunker force-pushed the html-templating+css-extraction branch 2 times, most recently from 1ffcef4 to 5493fae Compare May 1, 2020 16:56
@devlinjunker devlinjunker force-pushed the html-templating+css-extraction branch from 5493fae to 86999f6 Compare May 1, 2020 16:58
@devlinjunker devlinjunker merged commit 79d0953 into master May 3, 2020
@devlinjunker devlinjunker deleted the html-templating+css-extraction branch May 3, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant