Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added update_with_otp() method #148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krtschmr
Copy link

pull request for #147

@krtschmr krtschmr mentioned this pull request Jan 31, 2019
@mediafinger
Copy link
Contributor

mediafinger commented Aug 1, 2019

Imo this is application logic. If someone wants to secure certain actions with an OTP, this is already possible to do in any application. I am not convinced this has to be part of this (general) gem.

@krtschmr
Copy link
Author

krtschmr commented Aug 1, 2019

deivse has update_with_password

@mediafinger
Copy link
Contributor

I guess I would have told the person that implemented that in devise the same 😄

But now that it exists, it might make sense to offer the full functionality over the API. Your changes look sensible to me.

Too bad this gem does not have a Rails app to write tests against, to proof such changes work.


Btw: if you want to make the CI pass, you could adapt the script like this: #155 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants