Fix double failed attempts and add error code for invalid otp

[pdkproitf]

Fixed: #127 and #51

Add the following message into locales/devise.en.yml:

devise:
    failure:
       invalid_otp: "2FA verification code failed."

If you are enabling use backup code, the parameter otp_backup should be attached in your parameters request instead of otp_attempt.

[verenion]

I can confirm that this fixes the issues #28 and #127

[ChielHackman]

For me it fixed the issue to, but it breaks displaying the last_attempt warning.

Fixed it by adding the following to lib/devise_two_factor/strategies/two_factor_authenticatable.rb

if resource.failed_attempts == 2
  return fail!(:last_attempt)
else
  return fail!(:not_found_in_database)
end

This assumes you got max 3 attempts. Not sure how to get the max attempts from the devise initializer.

[pdkproitf]

@ChielHackman @ChielHackman You can use maximum_attempts to check resource maximum attempts.

[mediafinger]

Is this a different implementation for the same issue: PR #130 ?

[jeremy04]

Is this a different implementation for the same issue: PR #130 ?

Yes

[pdkproitf]

The master branch's code was changed from the time I submitted this pull request. So anyone who wants to fix this problem should consider the solution instead of using it.

[williantenfen]

any update on this?