Enable import/named rule for JavaScript (xojs#601)

devinrhode2 · Oct 8, 2021 · 5ae64a9 · 5ae64a9
1 parent 47dd820
commit 5ae64a9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/config/plugins.cjs b/config/plugins.cjs
@@ -200,9 +200,8 @@ module.exports = {
 		],
 		'import/first': 'error',
 
-		// Disabled as it doesn't work with TypeScript.
-		// This issue and some others: https://github.com/benmosher/eslint-plugin-import/issues/1341
-		// 'import/named': 'error',
+		// Enabled, but disabled on TypeScript (https://github.com/xojs/xo/issues/576)
+		'import/named': 'error',
 
 		'import/namespace': [
 			'error',

diff --git a/lib/options-manager.js b/lib/options-manager.js
@@ -413,6 +413,10 @@ const buildXOConfig = options => config => {
 
 		// Does not work when the TS definition exports a default const.
 		config.baseConfig.rules['import/default'] = 'off';
+
+		// Disabled as it doesn't work with TypeScript.
+		// This issue and some others: https://github.com/benmosher/eslint-plugin-import/issues/1341
+		config.baseConfig.rules['import/named'] = 'off';
 	}
 
 	config.baseConfig.settings['import/resolver'] = gatherImportResolvers(options);

diff --git a/test/options-manager.js b/test/options-manager.js
@@ -437,6 +437,7 @@ test('buildConfig: typescript', t => {
 		project: './tsconfig.json',
 		projectFolderIgnoreList: [/\/node_modules\/(?!.*\.cache\/xo-linter)/],
 	});
+	t.is(config.baseConfig.rules['import/named'], 'off');
 });
 
 test('buildConfig: typescript with parserOption', t => {