Refactoring main character text #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Alecell
requested changes
Apr 19, 2024
src/components/CharacterLimitMainText/CharacterLimit.module.scss
Outdated
Show resolved
Hide resolved
aalmeida00
requested changes
Apr 26, 2024
Alecell
requested changes
Apr 29, 2024
src/components/CharacterLimitMainText/CharacterLimit.module.scss
Outdated
Show resolved
Hide resolved
hxsggsz
reviewed
May 6, 2024
hxsggsz
previously approved these changes
May 6, 2024
Alecell
requested changes
May 8, 2024
There was a problem hiding this comment.
isso aqui não me parece estar integrado com a integração dos mocks de API
Alecell
reviewed
May 20, 2024
Comment on lines
+11
to
+16
| type Social = { | ||
| id: string; | ||
| maxLength: number; | ||
| socialName: string; | ||
| svg: string; | ||
| }; |
There was a problem hiding this comment.
tipos devem ser declarados do types file
Comment on lines
+29
to
+47
| const getSocialMedias = async (): Promise<void> => { | ||
| const socialMedias: SocialMedia[] = await SocialMediaService.fetch([]); | ||
| const value = socialMedias.map((socialMedia) => { | ||
| const length: number = socialMedia.postModes.reduce((acc, data) => { | ||
| if (!('text' in data.validators)) { | ||
| return 0; | ||
| } | ||
| const { maxLength } = data.validators.text; | ||
| return acc > maxLength ? acc : maxLength; | ||
| }, 0); | ||
| return { | ||
| id: socialMedia.id, | ||
| maxLength: length, | ||
| socialName: socialMedia.name, | ||
| svg: socialMedia.icon, | ||
| }; | ||
| }); | ||
| setSocials(value); | ||
| }; |
There was a problem hiding this comment.
Caramba isso ta muito esquisito
Comment on lines
+49
to
+51
| useEffect(() => { | ||
| void getSocialMedias(); | ||
| }, []); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382
Feature
Refatoração do componente, exclusão de outros componentes desnecessários ao redor e melhoramento dos testes do componente.
Visual evidences 🖼️
Checklist
Additional info
N/A