Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Silence warnings when using 'node:' protocol #956

Merged
merged 2 commits into from May 4, 2022
Merged

chore: Silence warnings when using 'node:' protocol #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8683aca
chore: Silence warnings when using builtins w/ 'node:' protocol
rschristian May 4, 2022
b70d7d0
docs: Adding changeset
rschristian May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-dryers-train.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'microbundle': patch
---

Silences warnings when using Node builtins with the 'node:...' protocol on imports. Warnings related to bare usage of these builtins were already silenced.
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Expand Up @@ -347,7 +347,7 @@ function createConfig(options, entry, format, writeMeta) {
// We want to silence rollup warnings for node builtins as we rollup-node-resolve threats them as externals anyway
// @see https://github.com/rollup/plugins/tree/master/packages/node-resolve/#resolving-built-ins-like-fs
if (options.target === 'node') {
external = external.concat(builtinModules);
external = [/node:.*/].concat(builtinModules);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposefully replaced external here as otherwise we get duplicates.

microbundle/src/index.js

Line 339 in 6c59174

let external = ['dns', 'fs', 'path', 'url'];

}

const peerDeps = Object.keys(pkg.peerDependencies || {});
Expand Down