Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding flag & docs for jsxFragment #930

Merged
merged 2 commits into from Mar 3, 2022

Conversation

rschristian
Copy link
Collaborator

@rschristian rschristian commented Feb 1, 2022

#809 (comment)

I removed the options.jsx === 'React.createElement' thing as it's no longer relevant with jsxFragmentFactory (see #623 (comment)) and we set default values in the CLI for both jsx and jsxFragment, so we don't really need extra fallback values.

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

🦋 Changeset detected

Latest commit: 8f6509f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ForsakenHarmony
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2022
#809 (comment)

I removed the `options.jsx === 'React.createElement'` thing as it's no longer relevant with `jsxFragmentFactory` (see #623 (comment)) and we set default values in the CLI for both `jsx` and `jsxFragment`, so we don't really need extra fallback values.
@ForsakenHarmony ForsakenHarmony merged commit fb0a437 into master Mar 3, 2022
@ForsakenHarmony ForsakenHarmony deleted the chore/jsx-fragment-flag branch March 3, 2022 17:09
@preact-bot preact-bot mentioned this pull request Mar 3, 2022
@bors
Copy link
Contributor

bors bot commented Mar 3, 2022

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants