Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mangle.json being overwritten with [object Object] #926

Merged
merged 2 commits into from Jan 20, 2022
Merged

Fix mangle.json being overwritten with [object Object] #926

merged 2 commits into from Jan 20, 2022

Conversation

developit
Copy link
Owner

Regression from #882.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2022 •
edited

⚠️ No Changeset found

Latest commit: 2cf63ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rschristian
rschristian approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, wonder what's tripping up the changset-bot comment? I noticed it the other night in wmr too. Seems to not update itself anymore.

@developit
Copy link
Owner Author

Funky, yeah. I just peeked and there are no issues mentioning this on changesets/changesets or changesets/bot. The logic for detecting added changesets seems pretty straightforward. Maybe I clicked too fast? haha

@developit developit merged commit f04c85a into master Jan 20, 2022
@developit developit deleted the fix-namecache-eol branch January 20, 2022 20:59
@preact-bot preact-bot mentioned this pull request Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@developit @rschristian