IgnoredReturnValue honors ignoreReturnValueAnnotations on parent
#7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
force-pushed
the
improve-IgnoredReturnValue
branch
from
c2de304
to
20e75c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7285 +/- ##
=========================================
Coverage 84.76% 84.77%
+ Complexity 3992 3991 -1
=========================================
Files 578 578
Lines 12026 12026
Branches 2477 2475 -2
=========================================
+ Hits 10194 10195 +1
Misses 606 606
+ Partials 1226 1225 -1 ☔ View full report in Codecov by Sentry. |
cortinico
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at #6499 with no success but I found this little bug.
Also, I think, that now the code is a bit easier to read.