Stop creating in-memory KtFile when file path is provided

[3flex]

Waiting on merge of:

• Remove FilePath #7235
• Remove PsiFile.basePath #7237
• Remove PsiFile.relativePath #7238
• Remove PsiFile.lineSeparator #7240

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.75%. Comparing base (1d6b738) to head (982dd37).

Files	Patch %	Lines
.../main/kotlin/io/github/detekt/parser/KtCompiler.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7250      +/-   ##
============================================
- Coverage     84.75%   84.75%   -0.01%     
- Complexity     3994     3996       +2     
============================================
  Files           577      577              
  Lines         12130    12133       +3     
  Branches       2484     2486       +2     
============================================
+ Hits          10281    10283       +2     
  Misses          624      624              
- Partials       1225     1226       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BraisGabin]

Is the last commit related with this PR? Any way, LGTM.

[3flex]

Is the last commit related with this PR?

It is, yes. If it's not done in AutoCorrectLevelSpec.kt then the tests will fail because the same PsiFile is being reused between tests, and the modified text persists between them. This wasn't a problem before because detekt would always create a new copy of every file it analysed, but that doesn't happen after this PR.

There may be scenarios in IDE or other usages where the same PsiFile is also reused so I figured it's safest to defend against that by making a similar change in KtFileModifier.kt