Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enable allRules = true and buildUponDefaultConfig = true #7054

Merged
merged 8 commits into from
Mar 23, 2024

Conversation

BraisGabin
Copy link
Member

This PR adds again #6844 because it was reverted in #7053. I have no idea how CI didn't catch that problem because it wasn't related with any other PR. It was a regression. There was a missing unit test and the functional test didn't run.

This PR is the same as #6844 except for the last commit.

The problem was that when the user doesn't defines a configuration we should use the default configuration. Even if the user defines buildUponDefaultConfig = false.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.67%. Comparing base (9cfe9f2) to head (b26aec0).

Files Patch % Lines
...ab/arturbosch/detekt/core/config/AllRulesConfig.kt 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7054      +/-   ##
============================================
+ Coverage     83.62%   83.67%   +0.04%     
- Complexity     3938     3942       +4     
============================================
  Files           578      578              
  Lines         12147    12133      -14     
  Branches       2517     2508       -9     
============================================
- Hits          10158    10152       -6     
+ Misses          733      730       -3     
+ Partials       1256     1251       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortinico cortinico added this to the 2.0.0 milestone Mar 23, 2024
@BraisGabin BraisGabin merged commit e6e5c1b into main Mar 23, 2024
21 checks passed
@BraisGabin BraisGabin deleted the fix-allrules branch March 23, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants