Split Gradle functional tests by Gradle version #7036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7036 +/- ##
=========================================
Coverage 83.79% 83.79%
Complexity 3941 3941
=========================================
Files 579 579
Lines 12119 12119
Branches 2511 2511
=========================================
Hits 10155 10155
Misses 710 710
Partials 1254 1254 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...src/functionalTestMinSupportedGradle/kotlin/io/gitlab/arturbosch/detekt/GradleVersionSpec.kt
Fixed
Show fixed
Hide fixed
...src/functionalTestMinSupportedGradle/kotlin/io/gitlab/arturbosch/detekt/GradleVersionSpec.kt
Fixed
Show fixed
Hide fixed
3flex
commented
Mar 11, 2024
| @@ -3,10 +3,12 @@ package io.gitlab.arturbosch.detekt | |||
| import io.gitlab.arturbosch.detekt.testkit.DslTestBuilder | |||
| import org.assertj.core.api.Assertions.assertThat | |||
| import org.gradle.testkit.runner.TaskOutcome | |||
| import org.gradle.testkit.runner.internal.PluginUnderTestMetadataReading | |||
There was a problem hiding this comment.
I don't like using an internal method here but if it's removed/changed in Gradle we can easily copy/paste into our project, it's quite self-contained.
BraisGabin
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues found while implementing #6489, #6913 and #7025