Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PathFilters from internal to public API #6814

Closed
wants to merge 1 commit into from

Conversation

3flex
Copy link
Member

@3flex 3flex commented Jan 4, 2024

This type is used in Rule so it should be part of the public API.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5280baa) 84.92% compared to head (6d7d65e) 84.92%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6814   +/-   ##
=========================================
  Coverage     84.92%   84.92%           
  Complexity     4139     4139           
=========================================
  Files           577      577           
  Lines         13247    13247           
  Branches       2447     2447           
=========================================
  Hits          11250    11250           
  Misses          779      779           
  Partials       1218     1218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin
Copy link
Member

Can we hold this PR? I have in mind some refactors in this area where I move all these code from api to core. The idea is that the Rule will not need to handle if it should run over a file or not. The core will check the configuration and only call the rule when it should check a file.

I can't advance right now on that because I have a lot of open PRs. They depend between each other and I can't continue because I'm on a branch hell right now. Reviews are more than welcome 🙏, I'm stuck.

@3flex
Copy link
Member Author

3flex commented Jan 4, 2024

Sure, I'll mark as a draft and come back to it later.

@3flex
Copy link
Member Author

3flex commented Jan 14, 2024

Closing in favour of #6866

@3flex 3flex closed this Jan 14, 2024
@3flex 3flex deleted the move-pathfilters branch January 16, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants