New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Rulesets and add first party Detekt extensions #5548
Conversation
|
...les-libraries/src/main/kotlin/io/gitlab/arturbosch/detekt/libraries/RuleLibrariesProvider.kt
Fixed
Show fixed
Hide fixed
...les-libraries/src/main/kotlin/io/gitlab/arturbosch/detekt/libraries/RuleLibrariesProvider.kt
Fixed
Show fixed
Hide fixed
...les-libraries/src/main/kotlin/io/gitlab/arturbosch/detekt/libraries/RuleLibrariesProvider.kt
Fixed
Show fixed
Hide fixed
...les-libraries/src/main/kotlin/io/gitlab/arturbosch/detekt/libraries/RuleLibrariesProvider.kt
Fixed
Show fixed
Hide fixed
max-height: 300px; | ||
overflow-y: scroll; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we ok with glitchy scrollbars? It might be a Chrome bug, or just me not knowing the whole CSS structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, probably not worth blocking on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker for sure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 It looks great. And thanks for all the doc updates :)
Still not clear how to avoid this???
Especially when using the maven plugin, NOT gradle. See my issue — Ozsie/detekt-maven-plugin#169. This issue states "provide a clear examples", but where can I find them? Ok, I found this, but it is still not what to add for the maven plugin (is it some configuration or dependency?). Adding a dependency like this does not help: <dependency>
<groupId>io.gitlab.arturbosch.detekt</groupId>
<artifactId>detekt-rules-libraries</artifactId>
<version>${detekt-maven-plugin.version}</version> <!-- is 1.22.0 -->
<scope>runtime</scope>
</dependency> |
Based on the scope in your above dependency, it's added to the wrong classpath. You added it to the runtime of your code, but it needs to be present on the classpath of the build when the Detekt plugin is executed. I commented on the original issue in the Maven plugin, let's continue there. |
Motivation
Got a build failure with Detekt 1.22.0 - TWiStErRob/net.twisterrob.sun#170
changed
style
tolibraries
but still got an error:looked for how to include "libraries" ruleset and found nothing.
What's in this PR?
Note: please excuse my React, these are the first lines I've ever written. Might need some touchup.