Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IgnoredReturnValue rule crash in parallel mode #5413

Merged
merged 1 commit into from Oct 16, 2022
Merged

Fix IgnoredReturnValue rule crash in parallel mode #5413

merged 1 commit into from Oct 16, 2022

Commits on Oct 14, 2022

  1. Fix IgnoredReturnValue rule crash in parallel mode 

    IgnoredReturnValue crashes due to the usage of a non-thread-safe collection operation.
The usage of `Iterable<T>.plus()` causes this problem.
The crash in parallel mode is fixed by iterating over each collection by itself.

See here for more details in detekt v1.21:
https://github.com/detekt/detekt/blob/32f6e22d9524804ebbb51d31e53cd28a84864ed6/detekt-rules-errorprone/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/IgnoredReturnValue.kt#L90

Closes #5403
    @schalkms
    schalkms committed Oct 14, 2022
    Copy the full SHA
    2d54b94 View commit details
    Browse the repository at this point in the history